removed todo statements

This commit is contained in:
2019-09-23 22:36:34 -06:00
parent 23637f1add
commit a4a653af04
2 changed files with 17 additions and 18 deletions

View File

@@ -27,13 +27,13 @@
<usages-collector id="statistics.file.extensions.edit">
<counts>
<entry key="html" value="274" />
<entry key="js" value="3418" />
<entry key="js" value="3427" />
</counts>
</usages-collector>
<usages-collector id="statistics.file.types.edit">
<counts>
<entry key="HTML" value="274" />
<entry key="JavaScript" value="3418" />
<entry key="JavaScript" value="3427" />
</counts>
</usages-collector>
<usages-collector id="statistics.file.extensions.open">
@@ -62,8 +62,8 @@
<file pinned="false" current-in-tab="true">
<entry file="file://$PROJECT_DIR$/script.js">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="319">
<caret line="88" column="41" lean-forward="true" selection-start-line="88" selection-start-column="41" selection-end-line="88" selection-end-column="41" />
<state relative-caret-position="90">
<caret line="6" column="12" selection-start-line="6" selection-start-column="12" selection-end-line="6" selection-end-column="12" />
</state>
</provider>
</entry>
@@ -179,12 +179,12 @@
<updated>1569214123580</updated>
<workItem from="1569214124878" duration="389000" />
<workItem from="1569214556532" duration="97000" />
<workItem from="1569214674667" duration="19376000" />
<workItem from="1569214674667" duration="19653000" />
</task>
<servers />
</component>
<component name="TimeTrackingManager">
<option name="totallyTimeSpent" value="19862000" />
<option name="totallyTimeSpent" value="20139000" />
</component>
<component name="ToolWindowManager">
<frame x="0" y="0" width="1280" height="800" extended-state="0" />
@@ -239,8 +239,8 @@
</entry>
<entry file="file://$PROJECT_DIR$/script.js">
<provider selected="true" editor-type-id="text-editor">
<state relative-caret-position="319">
<caret line="88" column="41" lean-forward="true" selection-start-line="88" selection-start-column="41" selection-end-line="88" selection-end-column="41" />
<state relative-caret-position="90">
<caret line="6" column="12" selection-start-line="6" selection-start-column="12" selection-end-line="6" selection-end-column="12" />
</state>
</provider>
</entry>

View File

@@ -4,7 +4,7 @@
* Note: use only the DOM API, not D3!
*/
function staircase() {
// ****** TODO: PART II ******
// ****** PART II ******
let bar = document.getElementById("chart1").children[0].children;
for(let i = 0; i < bar.length; i++){
bar[i].style.height = (i+1) * 10;
@@ -32,8 +32,7 @@ function update(data) {
// ****** TODO: PART III (you will also edit in PART V) ******
// TODO: Select and update the 'a' bar chart bars
//let chart1 = d3.select('#chart1').selectAll('rect');
// Select and update the 'a' bar chart bars
let barChart1 = d3.select('#barChart1')
.selectAll('rect')
.data(data);
@@ -64,7 +63,7 @@ function update(data) {
// TODO: Select and update the 'b' bar chart bars
// Select and update the 'b' bar chart bars
let barChart2 = d3.select('#barChart2')
.selectAll('rect')
.data(data);
@@ -95,7 +94,7 @@ function update(data) {
// TODO: Select and update the 'a' line chart path using this line generator
// Select and update the 'a' line chart path using this line generator
let aLineGenerator = d3.line()
.x((d, i) => iScale(i))
@@ -106,7 +105,7 @@ function update(data) {
line1.attr("d", aLineGenerator(data));
// TODO: Select and update the 'b' line chart path (create your own generator)
// Select and update the 'b' line chart path (create your own generator)
let bLineGenerator = d3.line()
.x((d, i) => iScale(i))
@@ -118,7 +117,7 @@ function update(data) {
// TODO: Select and update the 'a' area chart path using this area generator
// Select and update the 'a' area chart path using this area generator
let aAreaGenerator = d3.area()
.x((d, i) => iScale(i))
.y0(0)
@@ -128,7 +127,7 @@ function update(data) {
.select('path')
.attr("d", aAreaGenerator(data));
// TODO: Select and update the 'b' area chart path (create your own generator)
// Select and update the 'b' area chart path (create your own generator)
let bAreaGenerator = d3.area()
.x((d, i) => iScale(i))
@@ -139,7 +138,7 @@ function update(data) {
.select('path')
.attr("d", bAreaGenerator(data));
// TODO: Select and update the scatterplot points
// Select and update the scatterplot points
let scatterPlot = d3.select('#scatterplot')
.selectAll('circle')
@@ -157,7 +156,7 @@ function update(data) {
.attr('cy', d=> bScale(d.b))
.attr('r', 5);
// ****** TODO: PART IV ******
// ****** PART IV ******